-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding oauthn #690
Open
ZohebShaikh
wants to merge
33
commits into
main
Choose a base branch
from
adding-oauthn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding oauthn #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 92.33% 93.00% +0.67%
==========================================
Files 35 36 +1
Lines 1800 1974 +174
==========================================
+ Hits 1662 1836 +174
Misses 138 138 ☔ View full report in Codecov by Sentry. |
ZohebShaikh
force-pushed
the
adding-oauthn
branch
from
October 25, 2024 15:54
90fdb41
to
f38e0c3
Compare
DiamondJoseph
force-pushed
the
adding-oauthn
branch
5 times, most recently
from
November 8, 2024 12:32
bf18693
to
7c9779b
Compare
DiamondJoseph
force-pushed
the
adding-oauthn
branch
from
November 11, 2024 14:38
cf632d0
to
3b06ea0
Compare
… and updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to the authentication were investigated:-
Client Libraries
In the end I decided to not use them as we just need to make 2 requests and there is not that much error handling required as well ... We can look into integrating on of the above mentioned alternatives for the OAuth device flow integration.