Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update h5web to version 12 #173

Merged
merged 12 commits into from
Oct 9, 2024
Merged

Update h5web to version 12 #173

merged 12 commits into from
Oct 9, 2024

Conversation

PeterC-DLS
Copy link
Contributor

Fix conditional rendering in plot toolbar to conform with rules of hooks

…hooks for props

Also refactor handling of aspect type in config dialog to untangle states, remove
explicit default position state handling from modal and modeless dialogs, remove
default props from connected plot for React 19, and update hookz version
Simplify modal by combining its toggle and making it render conditionally. Also, simplify
null selection handler, flip y-axis of heatmap and image plots, update dependencies, fix
surface plot story data.
Add missing key to appended line data, trim logged multiline data, clean up
logging, remove plot config from client messages and fix its processing, make it plot
config option in message, move selection functions, and fix union field validation in
plot message
Remove obsolete key properties from tests, add colour map to image data creation
Copy link
Collaborator

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finding issues with the selections. If I delete individual or all selections, the selections are removed for the other clients, but not for the client holding the baton.

PeterC-DLS and others added 7 commits October 9, 2024 10:54
Also accept strings for enums, check for model validation errors
Rename some baton messages, improve initial baton toast text and minor
Also, add default colour and methods to selection interface and tweak and clean up
selection components
@PeterC-DLS PeterC-DLS added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 84f9803 Oct 9, 2024
2 checks passed
@PeterC-DLS PeterC-DLS deleted the update-h5web-12 branch October 9, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants