-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update h5web to version 12 #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hooks for props Also refactor handling of aspect type in config dialog to untangle states, remove explicit default position state handling from modal and modeless dialogs, remove default props from connected plot for React 19, and update hookz version
Simplify modal by combining its toggle and making it render conditionally. Also, simplify null selection handler, flip y-axis of heatmap and image plots, update dependencies, fix surface plot story data.
Add missing key to appended line data, trim logged multiline data, clean up logging, remove plot config from client messages and fix its processing, make it plot config option in message, move selection functions, and fix union field validation in plot message
Remove obsolete key properties from tests, add colour map to image data creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm finding issues with the selections. If I delete individual or all selections, the selections are removed for the other clients, but not for the client holding the baton.
Also accept strings for enums, check for model validation errors
Rename some baton messages, improve initial baton toast text and minor
Also, add default colour and methods to selection interface and tweak and clean up selection components
VictoriaBeilsten-Edmands
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conditional rendering in plot toolbar to conform with rules of hooks