-
Notifications
You must be signed in to change notification settings - Fork 0
Push code coverage to codecov #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once bogus test is removed, LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some config to avoid the annoying things like moving untested code causing a CI run to fail?
For numtracker I've gone for making the patch check informational only, and given a bit of leeway in the project coverage so dropping slightly is not a blocker. We should still aim for high coverage but adding pointless tests to raise coverage levels isn't the best use of time.
| run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info | ||
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renovate immediately updated this in numtracker
| uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5 | |
| uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5 |
This repo doesn't have any rules defined for what checks must pass for a PR to be mergable. I propose adding one with format/lint/test only? |

No description provided.