Skip to content

Conversation

@ZohebShaikh
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@dan-fernandes dan-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once bogus test is removed, LGTM 👍

@ZohebShaikh ZohebShaikh changed the title Push to codecov Push code covergae to codecov Oct 30, 2025
@ZohebShaikh ZohebShaikh changed the title Push code covergae to codecov Push code coverage to codecov Oct 30, 2025
Copy link
Contributor

@tpoliaw tpoliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some config to avoid the annoying things like moving untested code causing a CI run to fail?

For numtracker I've gone for making the patch check informational only, and given a bit of leeway in the project coverage so dropping slightly is not a blocker. We should still aim for high coverage but adding pointless tests to raise coverage levels isn't the best use of time.

run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info

- name: Upload coverage to Codecov
uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate immediately updated this in numtracker

Suggested change
uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5
uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5

@DiamondJoseph
Copy link

Can we add some config to avoid the annoying things like moving untested code causing a CI run to fail?

This repo doesn't have any rules defined for what checks must pass for a PR to be mergable. I propose adding one with format/lint/test only?

@DiamondJoseph
Copy link

Implemented as such:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants