Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and corresponding workflow #146

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Add Dockerfile and corresponding workflow #146

merged 1 commit into from
Aug 15, 2024

Conversation

namannimmo10
Copy link
Member

This is an attempt to build and push a docker image to the GitHub container registry using nvidia/cuda:11.6.2-devel-ubi8 as a base image. This newly built image can then be used for our GA workflows.

@namannimmo10
Copy link
Member Author

OK, the workflow succeeded. From the logs:

pushing ghcr.io/diamondlightsource/httomolibgpu:dockerfile with docker

@yousefmoazzam
Copy link
Contributor

Cool! 🎉 Can indeed see the built container image in https://github.com/diamondlightsource/httomolibgpu/pkgs/container/httomolibgpu

@dkazanc
Copy link
Collaborator

dkazanc commented Aug 15, 2024

thanks @namannimmo10 , so currently nothing is running in the container but it has got the conda environment for httomolibgpu?

@namannimmo10
Copy link
Member Author

namannimmo10 commented Aug 15, 2024

No this doesn't contain the dependencies for httomolibgpu. Hopefully, this will fix the issue we're having with #140 where git is unavailable. But similar approach could be followed to create a docker image for the library itself.

@namannimmo10
Copy link
Member Author

OK, this PR serves the purpose, I will merge it. We can certainly create an image for the library and push it with a different tag. This workflow won't run on the main branch.

@namannimmo10 namannimmo10 merged commit f3cbab4 into main Aug 15, 2024
3 checks passed
@namannimmo10 namannimmo10 deleted the dockerfile branch August 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants