Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector ROIs #113

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

stufisher
Copy link
Contributor

Allows the ROIs from a 2d detector to be specified in the database for downstream processing. I am open to discussion on this one. The idea is that the definition of the ROI is defined in json to support arbitrary types. This ROI can then be linked to an output XRFFluorescenceMapping (nothing to do with XRF but the table structure is consistent for any type of mapping) for traceability.

Is something like this useful to you @jacobfilik?

@stufisher stufisher marked this pull request as draft June 28, 2022 13:09
Copy link
Member

@KarlLevik KarlLevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with a table comment explaining what the table is for.

Also, there is no json_validate check on the definition column.

@stufisher
Copy link
Contributor Author

Should i move type into say DetectorROIType?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants