Skip to content

test: add BaseRelayWorkflow tests #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

test: add BaseRelayWorkflow tests #988

merged 1 commit into from
Nov 6, 2025

Conversation

@JamesDoingStuff
Copy link
Contributor

@JamesDoingStuff JamesDoingStuff commented Oct 24, 2025 •
edited
Loading

  • Adds tests for the BaseRelayWorkflow component. These largely overlap with existing tests for child components, but does also test the flow of data from this component down to the nodes of the flow box
  • Adds creator ID to mock templates, which will fix the query failure in the mock frontend workflows page
  • Tweaks the Accordion in WorkflowAccordion to be controlled i.e., change the expanded prop instead of defaultExpanded, which gets rids of console warnings.
  • For React Flows to appear in the tests and have the nodes be queryable, code found at https://reactflow.dev/learn/advanced-use/testing is implemented (with some minor modifications to satisfy the linter's type requirements, where possible)

@JamesDoingStuff JamesDoingStuff force-pushed the jg/baseworkflowrelay-tests branch from a961745 to 03c2b95 Compare October 24, 2025 16:27
@JamesDoingStuff JamesDoingStuff force-pushed the jg/baseworkflowrelay-tests branch 2 times, most recently from 7c41c39 to a54d1cc Compare October 28, 2025 12:00
@JamesDoingStuff JamesDoingStuff marked this pull request as ready for review October 28, 2025 14:27
@JamesDoingStuff
test(frontend): add tests for BaseWorkflowRelay
b986dc8 
test(frontend): update mock values
@JamesDoingStuff JamesDoingStuff force-pushed the jg/baseworkflowrelay-tests branch from a54d1cc to b986dc8 Compare October 30, 2025 13:55
TBThomas56
TBThomas56 reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@TBThomas56 TBThomas56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - think it worth having a second look before approval.

@JamesDoingStuff JamesDoingStuff merged commit 943ea49 into main Nov 6, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TBThomas56 TBThomas56 TBThomas56 left review comments

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands approved these changes

@davehadley davehadley Awaiting requested review from davehadley

@NatLeung96 NatLeung96 Awaiting requested review from NatLeung96

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JamesDoingStuff @VictoriaBeilsten-Edmands @TBThomas56