Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Add helm chart for postgresql database #382

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iamvigneshwars
Copy link
Collaborator

No description provided.

@iamvigneshwars iamvigneshwars added enhancement New feature or request helm Pull request that updates Helm charts labels Mar 6, 2024
@iamvigneshwars iamvigneshwars requested a review from garryod March 6, 2024 14:47
@iamvigneshwars iamvigneshwars self-assigned this Mar 6, 2024
@iamvigneshwars iamvigneshwars force-pushed the postgres-helm-chart branch 2 times, most recently from 5fc863f to 6b41921 Compare March 7, 2024 11:26
@iamvigneshwars iamvigneshwars force-pushed the postgres-helm-chart branch 2 times, most recently from 3d8cc64 to 5b8db2d Compare March 7, 2024 11:34
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the sealed secrets could just be secrets with randAlphaNum as we don't need them outside the deployment at all

charts/xchemlab/templates/init-script.yaml Outdated Show resolved Hide resolved
charts/xchemlab/templates/init-script.yaml Outdated Show resolved Hide resolved
charts/xchemlab/templates/pgpool-secret-sealed.yaml Outdated Show resolved Hide resolved
@iamvigneshwars iamvigneshwars force-pushed the postgres-helm-chart branch 3 times, most recently from 49269be to 4efcbad Compare March 12, 2024 15:51
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set up metrics and have them scraped by prometheus?

@@ -22,44 +22,44 @@ chimp-chomp:
compound-library:
enabled: true
database:
host: postgres://postgresql-ha-pgpool
user: postgres
host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to template this with the deployment name?

opa:
url: http://{{ .Release.Name }}-opa-kube-mgmt:8181

compound-soaking:
enabled: true
database:
host: postgres://postgresql-ha-pgpool
user: postgres
host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to template this with the deployment name?

opa:
url: http://{{ .Release.Name }}-opa-kube-mgmt:8181

crystal-library:
enabled: true
database:
host: postgres://postgresql-ha-pgpool
user: postgres
host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to template this with the deployment name?

opa:
url: http://{{ .Release.Name }}-opa-kube-mgmt:8181

pin-packing:
enabled: true
database:
host: postgres://postgresql-ha-pgpool
user: postgres
host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to template this with the deployment name?

@@ -77,11 +77,11 @@ targeting:
secretName: targeting-s3-secret
secretKey: secret-access-key
database:
host: postgres://postgresql-ha-pgpool
user: postgres
host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to template this with the deployment name?

Comment on lines 171 to 176
db-init.sql: |
SELECT 'CREATE DATABASE compound_library' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'compound_library')\gexec;
SELECT 'CREATE DATABASE compound_soaking' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'compound_soaking')\gexec;
SELECT 'CREATE DATABASE crystal_library' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'crystal_library')\gexec;
SELECT 'CREATE DATABASE targeting' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'targeting')\gexec;
SELECT 'CREATE DATABASE pin_packing' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'pin_packing')\gexec;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to move this to a configmap / secret somehow? Just to tidy up the values file

@iamvigneshwars iamvigneshwars force-pushed the postgres-helm-chart branch 3 times, most recently from 0e25a1f to f0e8807 Compare March 20, 2024 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request helm Pull request that updates Helm charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants