Replace pkg_resources with importlib #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmubashshir
force-pushed
the
importlib-migration
branch
from
f0c5ced to
4981ad5
Compare
pkg_resources is deprecated in favor of importlib.{resources,metadata}
Closes Diaoul#46
See-also: https://setuptools.pypa.io/en/latest/pkg_resources.html
See-also: https://docs.python.org/3/library/importlib.resources.html
See-also: https://docs.python.org/3/library/importlib.metadata.html
Signed-off-by: Mubashshir <[email protected]>
ahmubashshir
force-pushed
the
importlib-migration
branch
from
4981ad5 to
1905e78
Compare
Diaoul
approved these changes
Nov 18, 2023
|
Thanks for the PR and the library 👏 . Any chance to get the PR fixed @ahmubashshir and merged @Diaoul 🙏 ? |
|
|
The test failures are caused by setup-poetry action. |
|
@Diaoul Any chance you might look at this one? To not break under Python 3.13. |
|
New version is released 🚀 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources is deprecated in favor of importlib.{resources,metadata}
Closes #46
See-also: https://setuptools.pypa.io/en/latest/pkg_resources.html
See-also: https://docs.python.org/3/library/importlib.resources.html
See-also: https://docs.python.org/3/library/importlib.metadata.html
Signed-off-by: Mubashshir [email protected]