Fix defaults #30
Merged
Fix defaults #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better late than never 👴 |
|
Actually, going to revert this. Best is to implement defaulting from the spec and not at every problematic field. |
Merged
Diaoul
added a commit
that referenced
this pull request
Jun 23, 2024
Diaoul
pushed a commit
that referenced
this pull request
Jun 23, 2024
* Changed defaults according to specs * updated tests * Small error in defaults fixed
Diaoul
added a commit
that referenced
this pull request
Jun 23, 2024
Merged
Diaoul
added a commit
that referenced
this pull request
Jun 23, 2024
* Drop support for older Python versions * Migrate setup.py to pyproject.toml * Fixes #33 * Fix defaults (#30) * Changed defaults according to specs * updated tests * Small error in defaults fixed * Revert "Fix defaults (#30)" (#36) This reverts commit 45efa1f. * feat!: packaging, lint, test, ci --------- Co-authored-by: Henrique B. <[email protected]> Co-authored-by: Pascal Bourgault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small pull request to fix the problem highlighted in issue #29. Also, I changed all default values in to match those listed in the matroska specifications. (https://matroska.org/technical/specs/index.html)