This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
forked from DickinsonCollege/FarmData2
-
Notifications
You must be signed in to change notification settings - Fork 36
Test Seeding Type Filter #233
Draft
saiatl2354
wants to merge
21
commits into
DickinsonCollege:main
Choose a base branch
from
Comp290-Group:COMP290-04-FD2-Issue2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test Seeding Type Filter #233
saiatl2354
wants to merge
21
commits into
DickinsonCollege:main
from
Comp290-Group:COMP290-04-FD2-Issue2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like a good start. You appear to be testing that the appropriate summary table(s) appear. What you need to be testing is that the contents of the main report table has only the selected type(s) of seedings in it. |
To show that the dropdown has all of the seeding types you will need tests that generate different reports:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #185
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.