Test Seeding Report Tray Seeding Summary Values #234
Conversation
…eds planted per hour of the report table agrees with the data in the summary table Co-authored-by: Nathan Nguyen <[email protected]>
|
@braughtg This feature branch still contains old commits from previous features. Is there a way i can rebase this feature branch with main to remove these commits before closing the pull request? |
This typically happens when your work is based off of another feature branch. When you merge the As long as the "Files changed" tab just shows the new changes it will be fine when it is merged into |
| @@ -0,0 +1,79 @@ | |||
|
|
|||
| describe("Test the seeding report columns by seeding type", () => { | |||
| beforeEach(() => { | |||
There was a problem hiding this comment.
I think it would be an improvement to use a before here instead of a beforeEach so that the report is generated only once, and then split your it below into multiple tests, one for each quantity. That will better isolate the functionality being tested.
farmdata2/farmdata2_modules/fd2_barn_kit/seedingReport/seedingReport.data.spec.js
Outdated
Show resolved
Hide resolved
…ion to before function
|
If or when this is ready, just mark it as "Ready for review" and I'll look it over again in detail. |
Pull Request Description
Closes #207
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.