Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI issues with tagged releases #34

Open
Dids opened this issue Jul 23, 2018 · 3 comments
Open

Travis CI issues with tagged releases #34

Dids opened this issue Jul 23, 2018 · 3 comments
Assignees
Labels

Comments

@Dids
Copy link
Contributor

Dids commented Jul 23, 2018

Tagged releases break conditional support for Travis's stage system, which means that the tagged releases aren't getting pushed to nuget.org or to GitHub Releases.

More information here:
travis-ci/beta-features#40

@Dids Dids added the bug label Jul 23, 2018
@Dids Dids self-assigned this Jul 23, 2018
@Dids
Copy link
Contributor Author

Dids commented Jul 23, 2018

From what I can tell, a tagged release simply breaks conditionals entirely, so we might just have to drop using conditionals for now, and see if we can just use bash/shell expressions to validate if it's the correct branch and a tagged release or not.

@Dids
Copy link
Contributor Author

Dids commented Jul 23, 2018

This just keeps getting better.

For some reason Travis itself has no idea what branch of tag it's using:

Skipping a deployment with the script provider because this branch is not permitted: v1.0.0-beta8
Skipping a deployment with the script provider because this is not a tagged commit

@Dids
Copy link
Contributor Author

Dids commented Jul 23, 2018

Looks like we might just need to account for the following:

The documentation now reflects that TRAVIS_BRANCH is set to the tag name when the build was initiated by a tag.

However, it seems also reasonable to me that TRAVIS_BRANCH should be empty for tag builds. I do wonder if this change would break existing builds, however.

Source:
travis-ci/travis-ci#4745 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant