Improve/fix iso8601 timestamp parsing and generation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves compatibility with Logstash, Kibana, Grafana. Timezone always stored in UTC with "Z", and parsing supports fractions of a second.
|
This also removes the apparently-unused |
Events are already being stored in UTC, but unless the browser and server are in the same timezone, timestamps get munged. Using `picker.setLocalDate` is especially problematic. With this commit, everything is entered and displayed in UTC. The timezone *can* be made configurable, and it would probably make sense to allow users to enter times in their local timezone, but that's too much work for right now.
|
I had to switch to UTC for all entry and display of timestamps. Unless the browser and server are in the same timezone, the times would get munged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves compatibility with Logstash, Kibana, Grafana. Timezone always stored in UTC with "Z", and parsing supports fractions of a second.