Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional typing hints #54

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Conversation

Leengit
Copy link
Collaborator

@Leengit Leengit commented Jan 18, 2024

With the goal of making it easier to detect when errors are introduced with future code changes:

  • Adding types for additional variables and parameters.
  • Making mypy and tox / ruff complain less about the code.

Also, minor performance improvements like:

  • Invoking all(my_generator) rather than via list: all(list(my_generator)) or all([x for x in my_geneator]).
  • Invoking dict(zip(keys, values)) rather than {key: value for key, value in zip(keys, values)}

@Leengit Leengit merged commit 923d215 into DigitalSlideArchive:main Jan 26, 2024
6 checks passed
@Leengit Leengit deleted the more_typing branch January 26, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant