SSAO: reworked self-occlusion fix

DiligentGraphics · Jan 14, 2025 · 7756052 · 7756052
1 parent ede0b24
commit 7756052
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/Shaders/PostProcess/ScreenSpaceAmbientOcclusion/private/SSAO_ComputeAmbientOcclusion.fx b/Shaders/PostProcess/ScreenSpaceAmbientOcclusion/private/SSAO_ComputeAmbientOcclusion.fx
@@ -83,20 +83,17 @@ float ComputeAmbientOcclusionPS(in FullScreenTriangleVSOutput VSOut) : SV_Target
     if (IsBackground(PositionSS.z))
         discard;
 
-    // Trying to fix self-occlusion. Maybe there's a better way
+    float3 NormalVS = mul(float4(LoadNormalWS(ScreenCoordUV), 0.0), g_Camera.mView).xyz; 
+    float3 PositionVS = ScreenXYDepthToViewSpace(PositionSS, g_Camera.mProj);
+
+    // Fix self-occlusion
 #if SSAO_OPTION_HALF_PRECISION_DEPTH
-    float Epsilon = 0.000005;
+    float Offset = 0.005;
 #else
-    float Epsilon = 0.000001;
-#endif
-#if SSAO_OPTION_INVERTED_DEPTH
-    PositionSS.z *= 1.0 + Epsilon;
-#else
-    PositionSS.z *= 1.0 - Epsilon;
+    float Offset = 0.00001;
 #endif
+    PositionVS += NormalVS * Offset * PositionVS.z;
 
-    float3 NormalVS = mul(float4(LoadNormalWS(ScreenCoordUV), 0.0), g_Camera.mView).xyz; 
-    float3 PositionVS = ScreenXYDepthToViewSpace(PositionSS, g_Camera.mProj);
     float3 ViewVS = -normalize(PositionVS);
     float2 Xi = LoadRandomVector2D(int2(Position));