Hydrogent: use fixed depth bias for shadow pass

DiligentGraphics · Oct 17, 2024 · e9a4ef3 · e9a4ef3
1 parent 7cb5a24
commit e9a4ef3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/Hydrogent/interface/Tasks/HnTaskManager.hpp b/Hydrogent/interface/Tasks/HnTaskManager.hpp
@@ -46,6 +46,8 @@ struct HnRenderPassParams;
 struct HnReadRprimIdTaskParams;
 struct HnRenderBoundBoxTaskParams;
 
+class HnShadowMapManager;
+
 /// Task manager implementation in Hydrogent.
 class HnTaskManager
 {
@@ -236,7 +238,7 @@ class HnTaskManager
 
     void CreateBeginFrameTask();
     void CreateBeginMainPassTask();
-    void CreateRenderShadowsTask();
+    void CreateRenderShadowsTask(const HnShadowMapManager& ShadowMapMgr);
     void CreateRenderRprimsTask(const pxr::TfToken& MaterialTag, TaskUID UID, const HnRenderPassParams& RenderPassParams);
     void CreateRenderEnvMapTask(const pxr::TfToken& RenderPassName);
     void CreateRenderBoundBoxTask(const pxr::TfToken& RenderPassName);

diff --git a/Hydrogent/src/Tasks/HnTaskManager.cpp b/Hydrogent/src/Tasks/HnTaskManager.cpp
@@ -43,6 +43,7 @@
 #include "HashUtils.hpp"
 #include "HnRenderDelegate.hpp"
 #include "HnRenderPass.hpp"
+#include "HnShadowMapManager.hpp"
 
 namespace Diligent
 {
@@ -145,9 +146,9 @@ HnTaskManager::HnTaskManager(pxr::HdRenderIndex& RenderIndex,
 {
     // Task creation order defines the default task order
     CreateBeginFrameTask();
-    if (static_cast<const HnRenderDelegate*>(RenderIndex.GetRenderDelegate())->GetShadowMapManager())
+    if (const HnShadowMapManager* pShadowMapMgr = static_cast<const HnRenderDelegate*>(RenderIndex.GetRenderDelegate())->GetShadowMapManager())
     {
-        CreateRenderShadowsTask();
+        CreateRenderShadowsTask(*pShadowMapMgr);
     }
     CreateBeginMainPassTask();
 
@@ -261,13 +262,15 @@ void HnTaskManager::CreateBeginFrameTask()
     CreateTask<HnBeginFrameTask>(HnTaskManagerTokens->beginFrameTask, TaskUID_BeginFrame, TaskParams);
 }
 
-void HnTaskManager::CreateRenderShadowsTask()
+void HnTaskManager::CreateRenderShadowsTask(const HnShadowMapManager& ShadowMapMgr)
 {
     const USD_Renderer& Renderer = *static_cast<const HnRenderDelegate*>(GetRenderIndex().GetRenderDelegate())->GetUSDRenderer();
 
     HnRenderShadowsTaskParams TaskParams;
     TaskParams.State.DepthBiasEnabled     = true;
     TaskParams.State.SlopeScaledDepthBias = Renderer.GetSettings().PCFKernelSize * 0.5f + 0.5f;
+    const TEXTURE_FORMAT ShadowMapFmt     = ShadowMapMgr.GetAtlasDesc().Format;
+    TaskParams.State.DepthBias            = (ShadowMapFmt == TEX_FORMAT_D32_FLOAT || ShadowMapFmt == TEX_FORMAT_D32_FLOAT_S8X24_UINT) ? 10000 : 10;
     CreateTask<HnRenderShadowsTask>(HnTaskManagerTokens->renderShadowsTask, TaskUID_RenderShadows, TaskParams);
 
     // Only render shadows from default material for now