Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR: Reduced the number of buffer maps (close #48) #51

Merged
merged 1 commit into from
Jan 17, 2024
Merged

SSR: Reduced the number of buffer maps (close #48) #51

merged 1 commit into from
Jan 17, 2024

Conversation

MikhailGorobets
Copy link
Contributor

No description provided.

@TheMostDiligent
Copy link
Contributor

Let's rework this to completely avoid mapping buffer by using StartVertex = Index * 3 and computing draw call index in the vertex shader

TheMostDiligent
TheMostDiligent requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@TheMostDiligent TheMostDiligent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rework this to avoid mapping the buffer altogether

@MikhailGorobets MikhailGorobets force-pushed the ssr_fix_map branch 2 times, most recently from 950b0dc to 4698a8b Compare January 16, 2024 14:37
@MikhailGorobets MikhailGorobets force-pushed the ssr_fix_map branch 2 times, most recently from f9b26fc to 827dc2b Compare January 17, 2024 05:42
@TheMostDiligent TheMostDiligent force-pushed the ssr_fix_map branch 2 times, most recently from 3a98ff0 to 3bda9e5 Compare January 17, 2024 17:16
@TheMostDiligent TheMostDiligent force-pushed the ssr_fix_map branch 2 times, most recently from f90e4a9 to c1a8b1c Compare January 17, 2024 20:23
@TheMostDiligent TheMostDiligent merged commit 45ab80d into master Jan 17, 2024
55 checks passed
@TheMostDiligent TheMostDiligent deleted the ssr_fix_map branch January 17, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMostDiligent TheMostDiligent Awaiting requested review from TheMostDiligent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikhailGorobets @TheMostDiligent