Skip to content

Commit

Permalink
Merge pull request CesiumGS#831 from CesiumGS/fix-compute-load-progre…
Browse files Browse the repository at this point in the history
…ss-main-thread-q

Fix Tileset::ComputeLoadProgress incorrectly reporting done, when main thread loading exists
  • Loading branch information
j9liu authored Mar 30, 2024
2 parents bcdf4b6 + fd742c2 commit e0a1bea
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
##### Fixes :wrench:

- Fixed a bug where coordinates returned from `SimplePlanarEllipsoidCurve` were inverted if one of the input points had a negative height.
- Fixed a bug where `Tileset::ComputeLoadProgress` could incorrectly report 100% before all tiles finished their main thread loading.

### v0.33.0 - 2024-03-01

Expand Down
3 changes: 2 additions & 1 deletion Cesium3DTilesSelection/src/Tileset.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@ int32_t Tileset::getNumberOfTilesLoaded() const {

float Tileset::computeLoadProgress() noexcept {
int32_t queueSizeSum = static_cast<int32_t>(
this->_workerThreadLoadQueue.size() + this->_mainThreadLoadQueue.size());
this->_updateResult.workerThreadTileLoadQueueLength +
this->_updateResult.mainThreadTileLoadQueueLength);
int32_t numOfTilesLoading =
this->_pTilesetContentManager->getNumberOfTilesLoading();
int32_t numOfTilesLoaded =
Expand Down

0 comments on commit e0a1bea

Please sign in to comment.