MediaUIView - Fix image download bug (#2131)

[Taufi]

If the user has not yet granted permission to download photos, they will be asked to do so: PHPhotoLibrary.requestAuthorization(for: .addOnly). Afterward, the photos can also be downloaded to the desktop. Previously, broader access was granted (requestAuthorization(_:)), but this method is now deprecated. Apparently, Mac Catalyst support for more advanced permission checks is still not fully developed. Once permission is denied, it can no longer be granted in the settings. You have to do it via a terminal command: 'tccutil reset PhotosAdd <your.app.bundle.identifier>'.

[prodano-dev]

Is it possible to change the var status into a let and use a switch case? Or is the if statement necessary after the requestAuthorization for addOnly? I had something in mind like this:

private func saveImage(url: URL) async -> Bool {
        guard let image = try? await uiimageFor(url: url) else { return false }

        let status: PHAuthorizationStatus
        switch PHPhotoLibrary.authorizationStatus(for: .addOnly) {
        case .authorized:
            UIImageWriteToSavedPhotosAlbum(image, nil, nil, nil)
        default:
            await PHPhotoLibrary.requestAuthorization(for: .addOnly)
            status = PHPhotoLibrary.authorizationStatus(for: .addOnly)
        }
        return true
    }

Keeps it more readable without the if statements

[Taufi]

Thank you, D. Prodano, for your help. The guard statement is definitely a better solution than my if clause. Regarding the other if statements, my intention was to initiate the image download immediately after requesting authorization. Otherwise, the user would have to manually restart the download after granting authorization. What are your thoughts on this approach?

[ankushkushwaha]

Are we going to show empty description?

[Taufi]

Thank you for your question, Ankush.

When I leave the description empty, the pop-up displays the standard message: “‘Ice Cubes’ would like to add photos.” To me, this is sufficient, as the user has just pressed the button to download the photo, so everything should be clear.

However, when I add a description, the pop-up feels somewhat redundant:

What would you prefer?

[ankushkushwaha]

Okay thanks for the explanation, Its better to have some description for the user.

[Taufi]

I worked on improving the PR based on the reviewers' recommendations:

First, I updated the saveImage(url:) function in MediaUIView.swift as recommended by D. Prodano. I kept the second if clause to initiate the image download immediately after requesting authorization. I can change this if preferred, but it would then require the user to manually restart the download after granting authorization.

Additionally, I added the NSPhotoLibraryAddUsageDescription, following Ankush's recommendation.