Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Fix #260, #263, and #265 #262

Merged
merged 6 commits into from
Feb 17, 2024
Merged

✏️ Fix #260, #263, and #265 #262

merged 6 commits into from
Feb 17, 2024

Conversation

HeySreelal
Copy link
Contributor

Fix #260

The HttpClientException is now being exported with teledart.dart. This will let the users setup error handlers for the same.

@HeySreelal
Copy link
Contributor Author

Just refactored the test/ directory as well. The test/TeleDart_test.dart wasn't following the dart conventions and Linter wasn't too happy about it.

I just refactored the linter issue by renaming and adding one test. Let's consider adding more tests in the future.

@HeySreelal
Copy link
Contributor Author

Added one more commit, making the methods editMessageText, editMessageCaption, editMessageMedia, editMessageLiveLocation, stopMessageLiveLocation, and editMessageReplyMarkup to have the return type Future<dynamic> to be able to return either Message or bool as per the documentation. (Fixes #263).

@HeySreelal HeySreelal changed the title ✏️ Exports HttpClientException ✏️ Fix #260 and #263 Jan 21, 2024
@DinoLeung
Copy link
Owner

Thanks for your hard work @HeySreelal I'll be looking into this PR this weekend.

@HeySreelal HeySreelal changed the title ✏️ Fix #260 and #263 ✏️ Fix #260, #263, and #265 Feb 3, 2024
@HeySreelal
Copy link
Contributor Author

Also added fix for #265. Made the replyMarkup parameter in the Telegram.stopPoll method to be nullable as per the documentation.

@DinoLeung DinoLeung changed the base branch from master to feature/0.6.2 February 17, 2024 03:48
@DinoLeung DinoLeung merged commit ce431f1 into DinoLeung:feature/0.6.2 Feb 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClientException should be exported.
2 participants