Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian bumped to version 12 Bookworm / PHP bumped to version 8.2 / Secrets / Translation #103

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

luckylinux
Copy link

@luckylinux luckylinux commented Feb 8, 2024

Hi.

I'd like to suggest the following changes:

  • Use Debian 12 Bookworm image since that's the current stable distribution.
  • As an added benefit of Debian 12, PHP is also bumped to version 8.2.
  • In docker-compose.yml I chose to install latest mariadb
  • In docker-compose.yml I prefer to use SECRETS (instead of env) - Maybe just personal preference ?
  • Translation of comments in Dockerfile
  • (Deleted GitHub workflows directory since I am not uploading images to Dockerhub myself)
  • Use traefik proxy in docker-compose.yml (optional)

I'm using Podman instead of Docker, but the build succeeds and the program runs.

Create a build.sh script where the Dockerfile and glpi-start.sh are located with the following content.
This script assumes the name of the image to be derived from the last part of the path (i.e. if glpi is the image that needs to be built, the files need to be located in glpi folder together with the build.sh script)

#!/bin/bash

# Read this
# https://www.redhat.com/sysadmin/container-permission-denied-errors

# Define parameters
name=$(basename $PWD)

# Build image
podman build -t $name --cap-add all -f Dockerfile .

(unsure if necessarily all CAP_NET_XXX capabilities need to really be added)

Of course please REJECT the .github/workflows directory removal from my side.

Thanks for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant