Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Updated dependencies #42

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

GTP95
Copy link

@GTP95 GTP95 commented Oct 26, 2023

This pr updates the dependencies of all the examples, so that they compile using the latest version of Dioxus. It partially fixes issue #37 and should also fix the problems preventing the merge of pull request #41. Here is the status:

  • dog-app, ecommerce-site, and file-explorer work correctly
  • I couldn't test properly image_generator_open_ai and ios_demo, as I don't have an OpenAI API key and I don't own an iOS device. I can tell that the former compiles and starts correctly though.
  • wifi-scanner compiles and starts correctly, but is unable to find WiFi networks. But maybe it needs to run with root privileges.
  • jsframework-benchmark, todomvc, and weatherapp compile fine but then crash at runtime with the following error: thread 'main' panicked at 'cannot call wasm-bindgen imported functions on non-wasm targets'. I will not attempt to fix this though, so someone else would have to look into fixing these examples.

As a side note, it would probably be better to reorganize this repo in the future, so that the examples can be updated to new Dioxus versions separately, instead of forcing one to update all of them at the same time.

@GTP95
Copy link
Author

GTP95 commented Oct 26, 2023

I just saw that the problem with wifi-scanner is already discussed in issue #10, so my pr isn't introducing any new problem there.

This was referenced Oct 26, 2023
@ealmloff
Copy link
Member

jsframework-benchmark, todomvc, and weatherapp compile fine but then crash at runtime with the following error: thread 'main' panicked at 'cannot call wasm-bindgen imported functions on non-wasm targets'. I will not attempt to fix this though, so someone else would have to look into fixing these examples.

Those examples need to be served on the web with dx serve

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ealmloff ealmloff merged commit 0c9135c into DioxusLabs:master Oct 26, 2023
@GTP95 GTP95 deleted the update_dependencies branch October 28, 2023 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants