Call measure function on leaf nodes even if the node does not have context #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
added
usability
alice-i-cecile
approved these changes
Jan 2, 2024
Can't do that easily for this PR as the feature it changes also hasn't been added to RELEASES.md (oops). I'm on holiday this week, so I only have little bits of time. But hoping to get some time to focus on docs and release notes soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow use of measure functions in cases where extra context information is not required.
Context
Notes
I believe this is a strict generalisation of functionality. If users want to return a zero size for cases where context is
Nonethey can do this within their measure function (and asnode_contextwas already anOption<T>they would have to have done this anyway with the existing API).