Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 11 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 11 commits into from

Conversation

github-classroom[bot]
Copy link
Contributor

@github-classroom github-classroom bot commented May 13, 2023

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @FabioGal38

Copy link

@eliocamp eliocamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te dejé un par de comentarios en el código.


```{r}
defunciones_maternas_2009_2021 %>%
select(anio, cantidad) %>%

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En muchos de estos bloques no es necesario que selecciones sólo esas columnas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias profe, pero para el TP 2 no hice los cambios que me recomendo por miedo a que se me desconfigure el codigo.


```{r}
defunciones_maternas_2009_2021 %>%
filter(`region_sanitaria `== "VI") %>%

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenés que usar los `` por el espacio al final. Hay varias columnas con estos problemas (que deben provenir del archivo excel original). Mi recomendación es que las renombres al principio, luego de leer la tabla así no te molestan en el resto del análisis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants