Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP7 support and refactor migration file #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

norbybaru
Copy link

@norbybaru norbybaru commented May 19, 2024

Changes

  • Drop PHP7 support to enforce PHP8 upgrade as PHP7 has reached end-of-life support including security fixes.
  • Update migration file to publish migration file with current timestamp instead of the hard-coded timestamp. This is better for auditing to know when the file was generated.
  • Update the installation step to include the publish step for migration files for customization or applying default migration. this allows as well migration files to be version-controlled on the project.
  • Drop support for Laravel 5,6,7 as those have reached end-of-life support.

PS. This should probably be a major release to start migrating coding standards to PHP8.

@norbybaru norbybaru changed the title drop php7 support and refactor migration file Drop PHP7 support and refactor migration file May 19, 2024
@stevebauman
Copy link
Member

Hey @norbybaru, appreciate the PR!

I actually wanted to keep this package's great backwards compatibility until it's necessary to break it. I don't see why these changes are necessary, besides the improved migration naming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants