ML#123 - Ability To Set Global Custom Name #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kodinkat
commented
Oct 30, 2023
kodinkat
commented
- fixes: Ability to set custom name instead of "Magic link" #123
corsacca
reviewed
Nov 6, 2023
|
|
||
| add_filter( 'dt_magic_link_global_name', 'dt_magic_link_global_name', 10, 1 ); | ||
| function dt_magic_link_global_name( $global_name ) { | ||
| if ( Disciple_Tools_Bulk_Magic_Link_Sender_API::option_exists( Disciple_Tools_Bulk_Magic_Link_Sender_API::$option_dt_magic_links_global_name_enabled ) && boolval( Disciple_Tools_Bulk_Magic_Link_Sender_API::fetch_option( Disciple_Tools_Bulk_Magic_Link_Sender_API::$option_dt_magic_links_global_name_enabled ) ) === true ) { |
There was a problem hiding this comment.
@kodinkat this section will require 4 database calls. 2 is enough.
just use boolval and get_option( Disciple_Tools_Bulk_Magic_Link_Sender_API::$option_dt_magic_links_global_name_enabled, $default )
and then get_option again with a default set to ''
There was a problem hiding this comment.
replace Disciple_Tools_Bulk_Magic_Link_Sender_API::fetch_option() with the wp function. the wrapper seems unnecessary
corsacca
reviewed
Nov 6, 2023
admin/general-tab.php
Outdated
| } else { | ||
| $global_name_enabled_checked_html = boolval( Disciple_Tools_Bulk_Magic_Link_Sender_API::fetch_option( Disciple_Tools_Bulk_Magic_Link_Sender_API::$option_dt_magic_links_global_name_enabled ) ) ? 'checked' : ''; | ||
| } | ||
| $global_name_value = Disciple_Tools_Bulk_Magic_Link_Sender_API::option_exists( Disciple_Tools_Bulk_Magic_Link_Sender_API::$option_dt_magic_links_global_name ) ? Disciple_Tools_Bulk_Magic_Link_Sender_API::fetch_option( Disciple_Tools_Bulk_Magic_Link_Sender_API::$option_dt_magic_links_global_name ) : ''; |
There was a problem hiding this comment.
can be simplified to get_option( $key, '')
with the default being ''
|
Thanks @kodinkat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.