Add minimize to tray support. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about it, I could probably just use mutex to force single instance. I don't know why I overcomplicated it. |
|
Yeah, you can do that. Here's an example: // I use a class here to perform cleanup after winmain
class InstanceMutex
{
HANDLE m_handle = NULL;
public:
HRESULT Init()
{
#ifdef _DEBUG
return 0;
#else
SetLastError(NO_ERROR);
m_handle = CreateMutex(NULL, TRUE, WINDOW_CLASS);
if (GetLastError() == ERROR_ALREADY_EXISTS)
{
if (m_handle)
{
CloseHandle(m_handle);
m_handle = NULL;
}
return ERROR_ALREADY_EXISTS;
}
return GetLastError();
#endif
}
~InstanceMutex()
{
#ifdef _DEBUG
if (m_handle)
CloseHandle(m_handle);
#endif
}
};
InstanceMutex g_instanceMutex;
bool DetectDuplicateInstances()
{
HRESULT hres = g_instanceMutex.Init();
if (hres != ERROR_ALREADY_EXISTS) return false;
HWND hWnd = FindWindow(WINDOW_CLASS_NAME, NULL);
if (hWnd) {
SendMessage (hWnd, WM_REQUESTACTIVATE, 0, 0);
return true;
}
return false;
} |
iProgramMC
requested changes
Jun 27, 2024
iProgramMC
requested changes
Jun 27, 2024
Fix warnings.
iProgramMC
requested changes
Jun 29, 2024
| @@ -1580,21 +1580,21 @@ static bool ForceSingleInstance(LPCWSTR pClassName) | |||
| HRESULT hResult = g_instanceMutex.Init(); | |||
|
|
|||
| if (hResult != ERROR_ALREADY_EXISTS) | |||
| return false; | |||
| return true; | |||
|
|
|||
| HWND hWnd = FindWindow(pClassName, NULL); | |||
| if (hWnd) | |||
| { | |||
| SendMessage(hWnd, WM_RESTORE, 0, 0); | |||
| } | |||
There was a problem hiding this comment.
Return false in the condition, and true just below.
iProgramMC
previously requested changes
Jun 29, 2024
iProgramMC
reviewed
Jun 29, 2024
* Don't show the main window on startup. * Don't take focus to the main message box when the channel is switched if the window is not active. * Change `--startup` to `/startup`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.