Skip to content

Commit

Permalink
fix changelog and make exclude_deleted default to True
Browse files Browse the repository at this point in the history
  • Loading branch information
Snipy7374 committed Nov 26, 2024
1 parent b0e272b commit b5721c0
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion changelog/1113.feature.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ Support application subscriptions and one-time purchases (see the :ddocs:`offici
- New types: :class:`SKU`, :class:`Entitlement`.
- New :attr:`Interaction.entitlements` attribute, and :meth:`InteractionResponse.require_premium` response type.
- New events: :func:`on_entitlement_create`, :func:`on_entitlement_update`, :func:`on_entitlement_delete`.
- New :class:`Client` methods: :meth:`~Client.skus`, :meth:`~Client.entitlements`, :meth:`~Client.create_entitlement`.
- New :class:`Client` methods: :meth:`~Client.skus`, :meth:`~Client.entitlements`, :meth:`.Client.fetch_entitlement`, :meth:`~Client.create_entitlement`.
2 changes: 1 addition & 1 deletion changelog/1186.feature.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ Support application subscriptions and one-time purchases (see the :ddocs:`offici
- New types: :class:`SKU`, :class:`Entitlement`.
- New :attr:`Interaction.entitlements` attribute, and :meth:`InteractionResponse.require_premium` response type.
- New events: :func:`on_entitlement_create`, :func:`on_entitlement_update`, :func:`on_entitlement_delete`.
- New :class:`Client` methods: :meth:`~Client.skus`, :meth:`~Client.entitlements`, :meth:`~Client.create_entitlement`.
- New :class:`Client` methods: :meth:`~Client.skus`, :meth:`~Client.entitlements`, :meth:`.Client.fetch_entitlement`, :meth:`~Client.create_entitlement`.
7 changes: 5 additions & 2 deletions changelog/1249.feature.rst
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
- Add the new ``exclude_deleted``` argument to :meth:`.Client.entitlements`.
- Add the new :meth:`.Client.fetch_entitlement` method.
Support application subscriptions and one-time purchases (see the :ddocs:`official docs <monetization/overview>` for more info).
- New types: :class:`SKU`, :class:`Entitlement`.
- New :attr:`Interaction.entitlements` attribute, and :meth:`InteractionResponse.require_premium` response type.
- New events: :func:`on_entitlement_create`, :func:`on_entitlement_update`, :func:`on_entitlement_delete`.
- New :class:`Client` methods: :meth:`~Client.skus`, :meth:`~Client.entitlements`, :meth:`.Client.fetch_entitlement`, :meth:`~Client.create_entitlement`.
4 changes: 2 additions & 2 deletions disnake/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -3147,7 +3147,7 @@ def entitlements(
guild: Optional[Snowflake] = None,
skus: Optional[Sequence[Snowflake]] = None,
exclude_ended: bool = False,
exclude_deleted: bool = False,
exclude_deleted: bool = True,
oldest_first: bool = False,
) -> EntitlementIterator:
"""Retrieves an :class:`.AsyncIterator` that enables receiving entitlements for the application.
Expand Down Expand Up @@ -3188,7 +3188,7 @@ def entitlements(
exclude_ended: :class:`bool`
Whether to exclude ended/expired entitlements. Defaults to ``False``.
exclude_deleted: :class:`bool`
Whether to exclude deleted entitlements. Defaults to ``False``.
Whether to exclude deleted entitlements. Defaults to ``True``.
oldest_first: :class:`bool`
If set to ``True``, return entries in oldest->newest order. Defaults to ``False``.
Expand Down
2 changes: 1 addition & 1 deletion disnake/http.py
Original file line number Diff line number Diff line change
Expand Up @@ -2384,7 +2384,7 @@ def get_entitlements(
return self.request(r, params=params)

def get_entitlement(
self, application_id: Snowflake, *, entitlement_id: int
self, application_id: Snowflake, entitlement_id: int
) -> Response[entitlement.Entitlement]:
return self.request(
Route(
Expand Down
2 changes: 1 addition & 1 deletion disnake/iterators.py
Original file line number Diff line number Diff line change
Expand Up @@ -1044,7 +1044,7 @@ def __init__(
before: Optional[Union[Snowflake, datetime.datetime]] = None,
after: Optional[Union[Snowflake, datetime.datetime]] = None,
exclude_ended: bool = False,
exclude_deleted: bool = False,
exclude_deleted: bool = True,
oldest_first: bool = False,
) -> None:
if isinstance(before, datetime.datetime):
Expand Down

0 comments on commit b5721c0

Please sign in to comment.