Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new poll system message type #1213

Merged
merged 14 commits into from
Nov 21, 2024

Conversation

Snipy7374
Copy link
Collaborator

@Snipy7374 Snipy7374 commented Aug 6, 2024

Summary

This is something new for me so i want to ask if i need to add the new fields documented in the discord PR respectively to the Embed and Message class

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Aug 7, 2024
@Snipy7374 Snipy7374 marked this pull request as ready for review August 10, 2024 15:54
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
changelog/1212.feature.rst Outdated Show resolved Hide resolved
@Snipy7374 Snipy7374 requested a review from shiftinv September 2, 2024 08:26
@Snipy7374
Copy link
Collaborator Author

The "s: waiting for api/docs" label can now be removed 🙏🏻

@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Sep 2, 2024
@shiftinv
Copy link
Member

shiftinv commented Sep 5, 2024

edit: disregard this comment


Seeing how the poll result embeds are currently structured, I don't think we can represent them entirely in system_message - the result (with a clear winner) looks like this, for instance:
image
The closest would be something like the following, which doesn't really make sense on its own:

{author}'s poll {question} has closed.

{answer_text}
Winning answer • {maths}%

Just having the first line would be enough, in my opinion.

disnake/message.py Outdated Show resolved Hide resolved
@shiftinv shiftinv merged commit d95db29 into DisnakeDev:master Nov 21, 2024
26 of 27 checks passed
@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement new poll system message type
2 participants