-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete interactions/buttons.mdx page #60
base: main
Are you sure you want to change the base?
Conversation
- Add basic View example - Add example for handling timeout (disabling buttons and clear_items) - Move low level example to Views vs low-level section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty! This looks good, most of my comments are about formatting and other minor nits.
A more general comment about the entire guide's structure:
With the addition of this page, the guide starts having some redundancy between the pages for buttons and select menus, both regarding view timeouts and low-level components.
This isn't relevant to this PR directly, but we should refactor common sections into a separate page in the future.
I was thinking the same thing as I was working on this. |
remove unnecessary "default timeout" comment Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
correct View Example link Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
remove unneeded comment in disabled button example Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
adjust comment structure in button_view example Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
remove ellipses from example Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
remove unnecessary comment in timeout example Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
wording in timeout example slash command Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
remove unneeded custom_id check in low level example Co-authored-by: shiftinv <[email protected]> Signed-off-by: DLCHAMP <[email protected]>
reword comments in timeout example remove duplicate comments from second button callback.
Description
Complete the interactions/buttons page
Relevant Issues
Closes #59