Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: switch to swap network #2426

Merged
merged 1 commit into from
Oct 5, 2022
Merged

hotfix: switch to swap network #2426

merged 1 commit into from
Oct 5, 2022

Conversation

creed-victor
Copy link
Collaborator

No description provided.

@creed-victor creed-victor self-assigned this Oct 5, 2022
@netlify
Copy link

netlify bot commented Oct 5, 2022 •
edited
Loading

✅ Deploy Preview for legacy-dapp ready!

Name Link
🔨 Latest commit 52f7690
🔍 Latest deploy log https://app.netlify.com/sites/legacy-dapp/deploys/633d3ee2960ac60008c7991b
😎 Deploy Preview https://deploy-preview-2426--legacy-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@creed-victor creed-victor requested review from tiltom and pietro-maximoff and removed request for tiltom October 5, 2022 08:25
tiltom
tiltom reviewed Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@tiltom tiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested Swap and Spot and everything works fine for me (except lagging history but it's not a showstopper).

pietro-maximoff
pietro-maximoff approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@pietro-maximoff pietro-maximoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on the margin/spot pages with buy/sell for both - all works well, all transactions are successful and the same on swap page, made 3 random transactions - all works well

@tiltom tiltom requested a review from LunaSov October 5, 2022 09:17
@tiltom tiltom merged commit 123a370 into master Oct 5, 2022
@creed-victor creed-victor deleted the hotfix/swap-external branch October 5, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunaSov LunaSov LunaSov approved these changes

@pietro-maximoff pietro-maximoff pietro-maximoff approved these changes

@tiltom tiltom tiltom approved these changes

Assignees

@creed-victor creed-victor

Labels
hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@creed-victor @tiltom @pietro-maximoff @LunaSov