Transfer Ownership of contract from multisig to governance #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pauser role in priceFeeds Add deployment script for transferring ownership to governance Prettier and linting contract
korepkorep
reviewed
Jul 16, 2021
| @@ -23,6 +23,13 @@ contract ProtocolSettings is State, ProtocolTokenUser, ProtocolSettingsEvents { | |||
| using SafeERC20 for IERC20; | |||
| using SafeMath for uint256; | |||
|
|
|||
| address public admin; | |||
There was a problem hiding this comment.
admin should be in the State so it's easier to track storage layout
Comment on lines
+9
to
+10
| event AdminRemoved(address admin); |
eMarchenko
reviewed
Jul 26, 2021
| admin = _admin; | ||
| } | ||
|
|
||
| function getAdmin() external view returns (address) { |
There was a problem hiding this comment.
admin variable is public, so you don't need a separate getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add admin role in protocol settings
Add pauser role in priceFeeds
Add deployment script for transferring ownership to governance
Prettier and linting contract