Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pausing a single rune (smart contract upgrade) #2

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

koirikivi
Copy link
Collaborator

No description provided.

@tjcloa tjcloa requested a review from cwsnt August 6, 2024 19:34
Copy link
Collaborator

@tjcloa tjcloa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except:

  • one shadowing variable declaration - see inline comments
  • failing CI unit tests
  • integration tests skipped - is it on purpose?

external
onlyAdmin
{
if (paused != isRunePaused[rune]) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadows PausableUpgradable.paused

Copy link
Collaborator

@cwsnt cwsnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But it seems there is unit tests error in the GH CD

@koirikivi koirikivi merged commit 911ad6b into main Sep 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants