Type api/* #1407
Open
Type api/* #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchaffraix
force-pushed
the
julien_type_api
branch
2 times, most recently
from
3b03367 to
40913af
Compare
chrismiceli
approved these changes
Dec 26, 2024
70ray
approved these changes
Dec 27, 2024
|
@jchaffraix - Can you please break out the TrieNode changes into a separate PR we can get in first? This change makes sense but I'd like to review and merge it in separately than the typing changes. |
I have split the changes in api/ApiRouter.inc into #1411. This may be a bit more than what you asked as it includes some of the added typing in the class... Those seemed small enough they shouldn't impact the review, however let me know if you prefer that we break this further. |
The first step was to rework the ApiRouter to clearly state that it was using a trie and add an appropriate TrieNode. This helped clean up the types a bit. Typed the handlers/validators though their return value is anything that `json_encode` can consume (so anything effectively :-)).
cpeel
force-pushed
the
julien_type_api
branch
from
40913af to
94f29d0
Compare
|
@jchaffraix - I just rebased this to resolve the merge conflict from #1411 |
cpeel
approved these changes
Jan 19, 2025
chrismiceli
approved these changes
Jan 20, 2025
srjfoo
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step was to rework the ApiRouter to
clearly state that it was using a trie and add
an appropriate TrieNode. This helped clean up
the types a bit.
Typed the handlers/validators though their
return value is anything that
json_encodecan consume (so anything effectively :-)).