Use async and await for ajax #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismiceli
reviewed
Jan 8, 2025
scripts/api.js
Outdated
| if (!contentType || !contentType.includes("application/json")) { | ||
| throw new AjaxError("Incorrect response type", AJAX_ERROR_CODES.INCORRECT_RESPONSE_TYPE); | ||
| } | ||
| const responseData = await response.json(); |
There was a problem hiding this comment.
we probably shouldn't call .json() until after we confirm the response is ok.
There was a problem hiding this comment.
We need to decode the result even if it is not ok so this avoids doing it twice.
jchaffraix
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Seconding the suggestions by @chrismiceli around checking for HTTP errors and potential exceptions in .json.
|
Sandbox updated. |
chrismiceli
approved these changes
Jan 9, 2025
|
It's not doing quite what it should in the real application. |
|
Sandbox updated again. |
jchaffraix
approved these changes
Jan 11, 2025
cpeel
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
This is entirely outside my wheelhouse and I am happy to defer to @chrismiceli and @jchaffraix who have approved it.
srjfoo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current supported browsers can use async and await which need FF 52, Chrome 55, Safari 10.3.
This should make the code more comprehensible.
Sandbox at: https://www.pgdp.org/~rp31/c.branch/async_await
It should only affect pages using the page browser.