revise sending SR notifications assuming whole hour deadlines #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpeel
approved these changes
Dec 22, 2023
chrismiceli
approved these changes
Dec 24, 2023
srjfoo
approved these changes
Dec 24, 2023
windymilla
approved these changes
Dec 24, 2023
|
Note: We need to merge this in after the February deployment to PROD. |
70ray
force-pushed
the
improve_sr_notify
branch
from
16ec1a6 to
abc6d2b
Compare
|
Note to self: need to update dpadmin's crontab with the time change post-deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second stage of the revised method of sending SR end notifications. It should not be merged until at least 42 days after #987 or SR periods that have not been rounded up may fail to send notifications.
Sandbox at: https://www.pgdp.org/~rp31/c.branch/improve_sr_notify