Correct cell bg color for striped rows

[cpeel]

Fix setting the has-diff cell background color in Review Work for striped tables.

Task 2067

This is testable in: https://www.pgdp.org/~cpeel/c.branch/fix-review-work-style/

Specifically see srjfoo's diff in the sandbox vs the main TEST code -- you need to be a site admin or PF on TEST to see another user's diffs.

[windymilla]

Sorry I didn't get to review this yesterday.

Although this works, I was under the impression that !important should be avoided unless there is no alternative. Just looking online now, an example quote is at W3 schools:

Tip: It is good to know about the !important rule. You might see it in some CSS source code. However, do not use it unless you absolutely have to.

I think an alternative (which may have been considered) would be to (re-)specify more precisely than the striped-ness, something like (untested):

td.has-diff {
    background-color: @table-cell-ok-lowc;
}
...
table.theme_striped {
    tr:nth-child(even) {
        background-color: @page-background;
        td.has-diff {
            background-color: @table-cell-ok-lowc;
        }
    }
    tr:nth-child(odd) {
        background-color: @sidebar-background;
        td.has-diff {
            background-color: @table-cell-ok-lowc;
        }
    }
}

[cpeel]

I think an alternative (which may have been considered) would be to (re-)specify more precisely than the striped-ness, something like (untested):

I did consider that but I didn't like how the table theme CSS then had to "know" about the has-diff -- I wanted to keep them separate. That's why I went with the !important to have the has-diff override whatever else comes its way. It could very well be a poor solution we'll need to undo later but I wanted to start there.

[windymilla]

OK - I'm happy with that logic