Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL/URLSearchParams APIs #162

Merged
merged 30 commits into from
Sep 29, 2023
Merged

URL/URLSearchParams APIs #162

merged 30 commits into from
Sep 29, 2023

Conversation

Xmader
Copy link
Member

@Xmader Xmader commented Aug 11, 2023

No description provided.

@Xmader
Copy link
Member Author

Xmader commented Aug 11, 2023 •
edited
Loading

TODO: add tests (done)

@Xmader Xmader marked this pull request as ready for review August 22, 2023 19:56
Xmader added 19 commits August 25, 2023 01:05
@Xmader
refactor: move URL/URLSearchParams APIs into the url builtin_modules
63f3aed
@Xmader
feat: implement browser-style EventTarget
eb0523c
@Xmader
refactor: move DOMException into the dom-exception builtin_module
a32bb80
@Xmader
feat(XHR): initial implementation of the XMLHttpRequest (XHR) API
15048e0
@Xmader
fix(EventTarget): this in listener function should be the event target
c12de3a
@Xmader
feat(XHR): status, statusText, getResponseHeader, getAllResponseHeaders
df73b36
@Xmader
feat(XHR): get XMLHttpRequest working
fcd197e 
We are close to the spec!
@Xmader
feat(XHR): make XMLHttpRequest API globally available
4671dc1
@Xmader
feat(XHR): implement responseType == "text"
ff00b01
@Xmader
feat(XHR): pass processRequestBodyChunkLength and `processRequestEn…
a0e00de 
…dOfBody` callbacks to request function
@Xmader
feat(XHR): implement upload progress monitoring
024f63e
@Xmader
fix(XHR): typings
8b3517e
@Xmader
fix(XHR): typings for processResponse callback
01cb084
@Xmader
feat(XHR): handle timeout
b730be5
@Xmader
feat(XHR): xhr.onerror to handle network error
ed83f88
@Xmader
feat(XHR): print out network errors even then the error will be handl…
92fda8a 
…ed by `xhr.onerror`
@Xmader
feat(XHR): implement xhr.abort()
bc230b9
@Xmader
fix(XHR): readyState constants should be defined on the class instanc…
c51fd0a 
…e as well
@Xmader
fix(event-loop): keep loop running until the Python awaitable is done
de658c8 
event-loop shield
@Hamada-Distributed
Copy link
Contributor

@caleb-distributive I think this looks done. We good to merge it?

@zollqir zollqir merged commit f434da9 into main Sep 29, 2023
4 of 5 checks passed
@Xmader Xmader deleted the Xmader/feat/url branch March 5, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamada-Distributed Hamada-Distributed Hamada-Distributed approved these changes

@zollqir zollqir Awaiting requested review from zollqir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xmader @Hamada-Distributed @zollqir