Fix remaining memory bugs #443
Commits on Sep 24, 2024
-
fix:
Py_XDECREFrequires the GIL to be held, but it's unavailable a……fter Python finalization
-
fix: accessing a non-existent property on a Python
bytesin JS land…… should return `undefined` instead of throwing a Python error
-
fix: clean up SpiderMonkey when the PythonMonkey module gets destroyed
We cannot use `Py_AtExit(cleanup);` because the GIL is unavailable after Python finalization, no more Python APIs can be called.
-
fix: to fix memory corruption, use
PyUnicode_AsUTF8AndSizewith the…… string size when possible
-
fix: to fix memory corruption, use
PyUnicode_AsUTF8AndSizewith the…… string size when possible
-
fix:
PyEventLoop's destructor should not use any Python API, after ……the GIL is already handed over to another thread
-
fix:
PyUnicodeObjectneeds to be well-formed in a debug build of CP……ython Otherwise a `_PyObject_AssertFailed` error will be raised See: `_PyUnicode_CheckConsistency` https://github.com/python/cpython/blob/v3.11.3/Objects/unicodeobject.c#L594-L600, #L552-L553
-
refactor: replace the use of our own roundtrip
StrType::getValueme……thod with the simpler `JS_EncodeStringToUTF8` SpiderMonkey API
-
fix: properly handle the reference count when doing
list.concat()`PyList_SetItem` steals the reference, so we must increase the reference count by 1
-
perf: simply do a pythonic
result = list[:]to get a copy of all it……ems to the new list
Commits on Oct 1, 2024
-
Merge branch 'Xmader/feat/python-3.13-support' into Xmader/fix/fix-me…
…m-bugs-using-debug-build
-
fix: reference count for
array_fillSince each call of `PyList_SetItem` steals a reference (even if its to the same object), we need multiple references to it for it to steal Co-authored-by: Caleb Aikens <[email protected]>
-
set
GLOBAL_CX = nullin the final cleanup function since it's no lo……nger usable/useful after the context is destroyed
-
fix the reference count for dicts
test_get_default_not_foundin Pyt……hon 3.11 Something is double-free-ed during the final finalization: in a debug build of Python, `./Include/object.h:602: _Py_NegativeRefcount: Assertion failed: object has negative ref count` In non-debug build of Python, it simply segfaults at the end during finalization.
