Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Credits] Add Credits Screen to display all TV Cast & Crew #58

Merged
merged 10 commits into from
Jul 23, 2024
Merged

[Credits] Add Credits Screen to display all TV Cast & Crew #58

merged 10 commits into from
Jul 23, 2024

Conversation

Divinelink
Copy link
Owner

@Divinelink Divinelink commented Jul 22, 2024 •
edited
Loading

This pull requests introduces credits screen to display all aggregated credits for TV shows.

Screen.Recording.2024-07-23.at.6.23.41.PM.mov

@Divinelink Divinelink self-assigned this Jul 22, 2024
@Divinelink Divinelink added the enhancement New feature or request label Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 20 lines in your changes missing coverage. Please review.

Project coverage is 67.34%. Comparing base (4a1c8e8) to head (70d306b).

Files Patch % Lines
...om/divinelink/feature/details/ui/DetailsContent.kt 60.00% 6 Missing ⚠️
...inelink/core/ui/components/scaffold/AppScaffold.kt 64.28% 0 Missing and 5 partials ⚠️
...in/com/divinelink/core/model/credits/PersonRole.kt 25.00% 3 Missing ⚠️
...inelink/core/model/credits/SeriesCrewDepartment.kt 0.00% 2 Missing ⚠️
...kotlin/com/divinelink/core/model/details/Person.kt 0.00% 1 Missing ⚠️
...main/kotlin/com/divinelink/core/ui/EmptyContent.kt 50.00% 0 Missing and 1 partial ⚠️
...nelink/core/ui/components/details/cast/CastList.kt 96.00% 0 Missing and 1 partial ⚠️
...com/divinelink/feature/details/ui/DetailsScreen.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   66.14%   67.34%   +1.20%     
==========================================
  Files         273      275       +2     
  Lines        6540     6597      +57     
  Branches      906      922      +16     
==========================================
+ Hits         4326     4443     +117     
+ Misses       1837     1776      -61     
- Partials      377      378       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Divinelink Divinelink merged commit 83fa3a9 into main Jul 23, 2024
4 checks passed
@Divinelink Divinelink deleted the feature/credits-screen branch July 23, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Divinelink Divinelink

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Divinelink