Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Credits] Add Credits Screen to display all TV Cast & Crew #58

Merged
merged 10 commits into from
Jul 23, 2024
Merged

[Credits] Add Credits Screen to display all TV Cast & Crew #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
02ffe7f
feat: add credits module and screen
Divinelink Jul 18, 2024
c99764e
feat: setup credits screen
Divinelink Jul 18, 2024
73edf23
fix: insert crew and cast concurrently
Divinelink Jul 21, 2024
7906299
feat: add crew sorting on db query
Divinelink Jul 21, 2024
0895c84
fix: temporarily remove view all credits for movies
Divinelink Jul 21, 2024
cbf300c
fix: get account details and menu items from details use case
Divinelink Jul 21, 2024
d6de4ef
feat: update person role subheader to be multiline
Divinelink Jul 21, 2024
a89168f
test: add tests for media details fetch use case updates
Divinelink Jul 22, 2024
c9e3a34
test: add tests for credits view model and use case
Divinelink Jul 22, 2024
70d306b
test: add ui tests for credits
Divinelink Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ dependencies {
implementation(projects.feature.watchlist)
implementation(projects.feature.details)
implementation(projects.feature.settings)
implementation(projects.feature.credits)

// Firebase
implementation(platform(libs.firebase.bom))
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/kotlin/com/andreolas/movierama/navigation/MainGraph.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.andreolas.movierama.navigation

import com.divinelink.feature.credits.screens.destinations.CreditsScreenDestination
import com.divinelink.feature.details.screens.destinations.DetailsScreenDestination
import com.divinelink.feature.settings.screens.navgraphs.SettingsNavGraph
import com.divinelink.ui.screens.destinations.WatchlistScreenDestination
Expand All @@ -11,6 +12,7 @@ import com.ramcosta.composedestinations.annotation.NavHostGraph
annotation class MainGraph {
@ExternalDestination<DetailsScreenDestination>
@ExternalDestination<WatchlistScreenDestination>
@ExternalDestination<CreditsScreenDestination>
@ExternalNavGraph<SettingsNavGraph>
companion object Includes
}
6 changes: 3 additions & 3 deletions ...c/test/kotlin/com/andreolas/movierama/details/domain/usecase/AddToWatchlistUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package com.andreolas.movierama.details.domain.usecase

import com.andreolas.movierama.fakes.repository.FakeDetailsRepository
import com.divinelink.core.data.session.model.SessionException
import com.divinelink.core.datastore.SessionStorage
import com.divinelink.core.model.media.MediaType
import com.divinelink.core.testing.MainDispatcherRule
import com.divinelink.core.testing.repository.TestDetailsRepository
import com.divinelink.core.testing.storage.FakeEncryptedPreferenceStorage
import com.divinelink.core.testing.storage.FakePreferenceStorage
import com.divinelink.feature.details.usecase.AddToWatchlistParameters
Expand All @@ -22,13 +22,13 @@ class AddToWatchlistUseCaseTest {
val mainDispatcherRule = MainDispatcherRule()
private val testDispatcher = mainDispatcherRule.testDispatcher

private lateinit var repository: FakeDetailsRepository
private lateinit var repository: TestDetailsRepository

private lateinit var sessionStorage: SessionStorage

@Before
fun setUp() {
repository = FakeDetailsRepository()
repository = TestDetailsRepository()
}

@Test
Expand Down
6 changes: 3 additions & 3 deletions ...src/test/kotlin/com/andreolas/movierama/details/domain/usecase/DeleteRatingUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.andreolas.movierama.details.domain.usecase

import com.andreolas.movierama.fakes.repository.FakeDetailsRepository
import com.divinelink.core.commons.domain.data
import com.divinelink.core.data.session.model.SessionException
import com.divinelink.core.datastore.SessionStorage
import com.divinelink.core.model.media.MediaType
import com.divinelink.core.testing.MainDispatcherRule
import com.divinelink.core.testing.repository.TestDetailsRepository
import com.divinelink.core.testing.storage.FakeEncryptedPreferenceStorage
import com.divinelink.core.testing.storage.FakePreferenceStorage
import com.divinelink.feature.details.usecase.DeleteRatingParameters
Expand All @@ -23,13 +23,13 @@ class DeleteRatingUseCaseTest {
val mainDispatcherRule = MainDispatcherRule()
private val testDispatcher = mainDispatcherRule.testDispatcher

private lateinit var repository: FakeDetailsRepository
private lateinit var repository: TestDetailsRepository

private lateinit var sessionStorage: SessionStorage

@Before
fun setUp() {
repository = FakeDetailsRepository()
repository = TestDetailsRepository()
}

@Test
Expand Down
6 changes: 3 additions & 3 deletions ...lin/com/andreolas/movierama/details/domain/usecase/FetchAccountMediaDetailsUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package com.andreolas.movierama.details.domain.usecase

import com.andreolas.factories.details.domain.model.account.AccountMediaDetailsFactory
import com.andreolas.movierama.fakes.repository.FakeDetailsRepository
import com.divinelink.core.commons.domain.data
import com.divinelink.core.data.details.model.MediaDetailsParams
import com.divinelink.core.data.session.model.SessionException
import com.divinelink.core.datastore.SessionStorage
import com.divinelink.core.model.media.MediaType
import com.divinelink.core.testing.MainDispatcherRule
import com.divinelink.core.testing.repository.TestDetailsRepository
import com.divinelink.core.testing.storage.FakeEncryptedPreferenceStorage
import com.divinelink.core.testing.storage.FakePreferenceStorage
import com.google.common.truth.Truth.assertThat
Expand All @@ -23,13 +23,13 @@ class FetchAccountMediaDetailsUseCaseTest {
val mainDispatcherRule = MainDispatcherRule()
private val testDispatcher = mainDispatcherRule.testDispatcher

private lateinit var repository: FakeDetailsRepository
private lateinit var repository: TestDetailsRepository

private lateinit var sessionStorage: SessionStorage

@Before
fun setUp() {
repository = FakeDetailsRepository()
repository = TestDetailsRepository()
}

@Test
Expand Down
Loading
Loading