Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Network Monitor to Detect Offline Mode #70

Merged
merged 16 commits into from
Sep 13, 2024

Conversation

Divinelink
Copy link
Owner

@Divinelink Divinelink commented Sep 13, 2024

This pull request adds a Network Monitor that detects changes in network status and notifies the user when they are offline by displaying a snackbar.

Additional enhancements include:

  • Improved offline error handling for homepage API calls (such as fetching popular items and performing searches).
  • Updates to blank slate components and illustrations.
  • Color adjustments to the search bar.
  • Version bumps for Compose BOM and Material3.

@Divinelink Divinelink added the enhancement New feature or request label Sep 13, 2024
@Divinelink Divinelink self-assigned this Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 72.90640% with 55 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (c22c239) to head (bb487fe).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
.../data/network/ConnectivityManagerNetworkMonitor.kt 0.00% 36 Missing ⚠️
...kotlin/com/andreolas/movierama/ui/MovieAppState.kt 60.00% 6 Missing ⚠️
...n/com/andreolas/movierama/home/ui/HomeViewModel.kt 92.30% 0 Missing and 4 partials ⚠️
...link/core/ui/components/details/SpannableRating.kt 88.88% 2 Missing and 1 partial ⚠️
...in/kotlin/com/divinelink/core/ui/FavoriteButton.kt 0.00% 1 Missing and 1 partial ⚠️
...n/com/andreolas/movierama/home/ui/HomeViewState.kt 94.11% 0 Missing and 1 partial ⚠️
.../kotlin/com/divinelink/core/model/home/HomePage.kt 66.66% 1 Missing ⚠️
...in/com/divinelink/core/ui/blankslate/BlankSlate.kt 90.90% 0 Missing and 1 partial ⚠️
...nelink/feature/details/media/ui/rate/RateSlider.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   72.20%   72.07%   -0.13%     
==========================================
  Files         350      354       +4     
  Lines        8184     8309     +125     
  Branches     1116     1132      +16     
==========================================
+ Hits         5909     5989      +80     
- Misses       1779     1826      +47     
+ Partials      496      494       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Divinelink Divinelink merged commit 631963c into main Sep 13, 2024
3 of 4 checks passed
@Divinelink Divinelink deleted the feature/network-detection branch September 13, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant