This repository has been archived by the owner on Oct 23, 2019. It is now read-only.
[WIP]Feat/local database #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roosemberth
force-pushed
the
feat/API_client
branch
9 times, most recently
from
d65ea3f to
ad5860b
Compare
roosemberth
force-pushed
the
feat/local_database
branch
from
afa53e7 to
65dedc7
Compare
roosemberth
suggested changes
Dec 18, 2018
| import ch.epfl.sweng.erpa.database.converter.*; | ||
| import ch.epfl.sweng.erpa.model.*; | ||
|
|
||
| @Database(entities = {Game.class, PlayerJoinGameRequest.class, UserAuth.class, Username.class, UserProfile.class, UserSessionToken.class}, version = 1) |
There was a problem hiding this comment.
Can you please restructure into -140 character lines?
| } | ||
|
|
||
|
|
||
| private static final BiMap<Integer, PlayerJoinGameRequest.RequestStatus> requestStatusConversionMap = genRequestStatusConversionMap(); |
There was a problem hiding this comment.
Please use @Getter(lazy=true)
|
|
||
| /** | ||
| * Builds a conversion map for the RequestStatus enum | ||
| */ |
There was a problem hiding this comment.
Superfluous comments, this is simple enough to be understood from the reference name.
| result.put(10, Game.Difficulty.NOOB); | ||
| result.put(20, Game.Difficulty.CHILL); | ||
| result.put(30, Game.Difficulty.HARD); | ||
| assert conversionMapHasAll(result, Game.Difficulty.values()); |
| @Data | ||
| @Builder(toBuilder = true) | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class Game implements UuidObject { | ||
| @NonNull private String uuid; | ||
| @android.support.annotation.NonNull @PrimaryKey @NonNull private String uuid = ""; |
There was a problem hiding this comment.
Please remove the "" default value.
| @ColumnInfo @NonNull private Difficulty difficulty; | ||
| @ColumnInfo @NonNull private String universe; | ||
| @ColumnInfo @NonNull private Boolean isCampaign; | ||
| @ColumnInfo @NonNull private Optional<Integer> numberOfSessions; |
There was a problem hiding this comment.
Did you forget to specify the column name? or the name attribute in lines 30 and 31 is superfluos?
| public class PlayerJoinGameRequest { | ||
| @NonNull private String joinRequestId; | ||
| @android.support.annotation.NonNull @PrimaryKey @NonNull private String joinRequestId = ""; |
There was a problem hiding this comment.
Please remove the default value
| @NonNull private String userUuid; | ||
| @NonNull private String username; | ||
| @ColumnInfo | ||
| @android.support.annotation.NonNull @PrimaryKey @NonNull private String username = ""; |
There was a problem hiding this comment.
Please remove the default value
| @NonNull private String userUuid; | ||
| @NonNull private String sessionToken; | ||
| @PrimaryKey @android.support.annotation.NonNull @NonNull private String sessionToken = ""; |
There was a problem hiding this comment.
Please remove the default value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.