Add Google Tag Manager and cookie consent #943
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 80.94% 81.24% +0.29%
==========================================
Files 95 98 +3
Lines 2850 2938 +88
Branches 268 271 +3
==========================================
+ Hits 2307 2387 +80
- Misses 492 499 +7
- Partials 51 52 +1
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -3,6 +3,14 @@ | |||
| <!DOCTYPE HTML> | |||
| <html> | |||
| <head> | |||
| <!-- Google tag (gtag.js) --> | |||
| <script async src="https://www.googletagmanager.com/gtag/js?id=G-JGJW1VEY0D"></script> | |||
There was a problem hiding this comment.
This gets loaded regardless of the cookie consent choice, so what functionality is listening out for that consent?
There was a problem hiding this comment.
Thanks, let me add that functionality.
There was a problem hiding this comment.
@marksweb, I followed the guidelines here https://developers.google.com/analytics/devguides/collection/gtagjs/user-opt-out to disable the google tag on cookie reject.
Changes in this PR:
The cookie consent dialogue looks as below:
