Handle 404 errors in fetch_stories #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
=======================================
Coverage 81.24% 81.24%
=======================================
Files 98 98
Lines 2938 2938
Branches 271 271
=======================================
Hits 2387 2387
Misses 499 499
Partials 52 52 Continue to review full report in Codecov by Sentry.
|
dostogircse171
changed the title
marksweb
requested changes
Feb 18, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
marksweb
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue encountered when fetching blog posts with images that result in a 404 error. By implementing error handling for these cases, the fetch_stories command can now gracefully skip over images that are not found, ensuring that the process continues to fetch and store all available blog posts without interruption and Image (If 404).
This approach ensures that individual failures due to missing images do not halt the overall execution, improving the reliability and robustness of our blog post fetching mechanism.
Fixes #949