Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event number in slug to fix HttpError migrating emails #954

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

amakarudze
Copy link
Contributor

Changes in this pull request:

  • Add a try ... except block to the migrate_gmail_account(new_event, slug) function.
  • Create the email if the except block if the try block fails.
  • Add regex to the get_or_create_gmail(event_application, event) function to remove event numbering in the slug which is causing the HttpError: 404 not found causing email migration issues.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (6a05d70) to head (d20737f).
Report is 46 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
+ Coverage   81.01%   81.26%   +0.25%     
==========================================
  Files          95       98       +3     
  Lines        2860     2941      +81     
  Branches      269      271       +2     
==========================================
+ Hits         2317     2390      +73     
- Misses        492      499       +7     
- Partials       51       52       +1     

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a05d70...d20737f. Read the comment docs.

@amakarudze amakarudze merged commit fda732f into DjangoGirls:main Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants