Delete DuplicateAttributeCheck

Dlang-UPB · Feb 20, 2024 · 189d000 · 189d000
1 parent 2bf728f
commit 189d000
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 271 deletions.
diff --git a/changelog/dscanner.duplicate-attribute-check.dd b/changelog/dscanner.duplicate-attribute-check.dd
@@ -0,0 +1,2 @@
+Remove the check for duplicate attributes (@property, @safe, @trusted, @system, pure, nothrow).
+This check is no longer necessary since having duplicated attributes is now a compiler error.
diff --git a/src/dscanner/analysis/duplicate_attribute.d b/src/dscanner/analysis/duplicate_attribute.d
diff --git a/src/dscanner/analysis/run.d b/src/dscanner/analysis/run.d
@@ -40,7 +40,6 @@ import dscanner.analysis.constructors;
 import dscanner.analysis.unused_variable;
 import dscanner.analysis.unused_label;
 import dscanner.analysis.unused_parameter;
-import dscanner.analysis.duplicate_attribute;
 import dscanner.analysis.opequals_without_tohash;
 import dscanner.analysis.length_subtraction;
 import dscanner.analysis.builtin_property_names;
@@ -840,10 +839,6 @@ private BaseAnalyzer[] getAnalyzersForModuleAndConfig(string fileName,
 		checks ~= new UnmodifiedFinder(args.setSkipTests(
 		analysisConfig.could_be_immutable_check == Check.skipTests && !ut));
 
-	if (moduleName.shouldRun!DuplicateAttributeCheck(analysisConfig))
-		checks ~= new DuplicateAttributeCheck(args.setSkipTests(
-		analysisConfig.duplicate_attribute == Check.skipTests && !ut));
-
 	if (moduleName.shouldRun!FunctionAttributeCheck(analysisConfig))
 		checks ~= new FunctionAttributeCheck(args.setSkipTests(
 		analysisConfig.function_attribute_check == Check.skipTests && !ut));