Replace libdparse with DMD in UselessInitializerChecker (#121)

* Replace libdparse with DMD in UselessInitializerChecker * Address feedback
Dlang-UPB · Aug 12, 2024 · 655fc46 · 655fc46
1 parent dffbf3a
commit 655fc46
Show file tree

Hide file tree

Showing 2 changed files with 213 additions and 275 deletions.
diff --git a/src/dscanner/analysis/run.d b/src/dscanner/analysis/run.d
@@ -850,10 +850,6 @@ private BaseAnalyzer[] getAnalyzersForModuleAndConfig(string fileName,
 		checks ~= new VcallCtorChecker(args.setSkipTests(
 		analysisConfig.vcall_in_ctor == Check.skipTests && !ut));
 
-	if (moduleName.shouldRun!UselessInitializerChecker(analysisConfig))
-		checks ~= new UselessInitializerChecker(args.setSkipTests(
-		analysisConfig.useless_initializer == Check.skipTests && !ut));
-
 	if (moduleName.shouldRun!AllManCheck(analysisConfig))
 		checks ~= new AllManCheck(args.setSkipTests(
 		analysisConfig.allman_braces_check == Check.skipTests && !ut));
@@ -1358,6 +1354,12 @@ MessageSet analyzeDmd(string fileName, ASTCodegen.Module m, const char[] moduleN
 			config.body_on_disabled_func_check == Check.skipTests && !ut
 		);
 
+	if (moduleName.shouldRunDmd!(UselessInitializerChecker!ASTCodegen)(config))
+		visitors ~= new UselessInitializerChecker!ASTCodegen(
+			fileName,
+			config.useless_initializer == Check.skipTests && !ut
+		);
+
 	foreach (visitor; visitors)
 	{
 		m.accept(visitor);