Replace libdparse with DMD in UndocumentedDeclarationCheck

Dlang-UPB · Nov 8, 2024 · 9923e70 · 9923e70
1 parent f6bfa57
commit 9923e70
Show file tree

Hide file tree

Showing 3 changed files with 177 additions and 260 deletions.
diff --git a/src/dscanner/analysis/run.d b/src/dscanner/analysis/run.d
@@ -659,10 +659,6 @@ BaseAnalyzer[] getAnalyzersForModuleAndConfig(string fileName,
 		checks ~= new FunctionAttributeCheck(args.setSkipTests(
 		analysisConfig.function_attribute_check == Check.skipTests && !ut));
 
-	if (moduleName.shouldRun!UndocumentedDeclarationCheck(analysisConfig))
-		checks ~= new UndocumentedDeclarationCheck(args.setSkipTests(
-		analysisConfig.undocumented_declaration_check == Check.skipTests && !ut));
-
 	return checks;
 }
 

diff --git a/src/dscanner/analysis/rundmd.d b/src/dscanner/analysis/rundmd.d
@@ -48,6 +48,7 @@ import dscanner.analysis.redundant_storage_class : RedundantStorageClassCheck;
 import dscanner.analysis.static_if_else : StaticIfElse;
 import dscanner.analysis.style : StyleChecker;
 import dscanner.analysis.trust_too_much : TrustTooMuchCheck;
+import dscanner.analysis.undocumented : UndocumentedDeclarationCheck;
 import dscanner.analysis.unmodified : UnmodifiedFinder;
 import dscanner.analysis.unused_label : UnusedLabelCheck;
 import dscanner.analysis.unused_parameter : UnusedParameterCheck;
@@ -339,6 +340,12 @@ MessageSet analyzeDmd(string fileName, ASTCodegen.Module m, const char[] moduleN
 			config.if_constraints_indent == Check.skipTests && !ut
 		);
 
+	if (moduleName.shouldRunDmd!(UndocumentedDeclarationCheck!ASTCodegen)(config))
+		visitors ~= new UndocumentedDeclarationCheck!ASTCodegen(
+			fileName,
+			config.undocumented_declaration_check == Check.skipTests && !ut
+		);
+
 	foreach (visitor; visitors)
 	{
 		m.accept(visitor);