Replace libdparse with DMD in UnmodifiedFinder #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladiwostok
force-pushed
the
unmodified-finder
branch
3 times, most recently
from
1139e3f
to
f2cfc49
Compare
Vladiwostok
force-pushed
the
unmodified-finder
branch
from
f2cfc49
to
5d4ef55
Compare
RazvanN7
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar too #116 .
This check looks for variables that remain unmodified and are not marked as such (const, immutable).
The libdparse version of the check is not that smart:
newexpressions or casts;a.someFunc()makes a "modified")I haven't modified the existing tests, but I've added many more to cover existing behavior.